fix: Adjustments to tabs components to prevent overflows #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Slaughter <[email protected]>
Signed-off-by: Josh Slaughter <[email protected]>
jdslaugh
requested review from
Golodhros,
ttannis,
allisonsuarez,
feng-tao,
verdan,
mgorsk1,
sewardgw,
youngyjd,
dechoma,
kristenarmes,
ozandogrultan and
B-T-D
as code owners
Golodhros
approved these changes
Nov 25, 2024
Comment on lines
+123
to
+124
| padding: 8px 0px 0px 14px; | ||
| margin-bottom: -16px; |
There was a problem hiding this comment.
Could we use spacer- tokens here?
jecr
reviewed
Dec 4, 2024
Comment on lines
+123
to
+124
| padding: 8px 0px 0px 14px; | ||
| margin-bottom: -16px; |
There was a problem hiding this comment.
Suggested change
| padding: 8px 0px 0px 14px; | |
| margin-bottom: -16px; | |
| padding: $spacer-1 0px 0px 14px; | |
| margin-bottom: -$spacer-2; |
B-T-D
approved these changes
Dec 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
css/_layouts.scss- Removed the min-heights and instead let it utilize the height of its container, which wont force it past acceptable limitsTable/styles.scss- increasedmin-widthto 100% to fill the container, set the header widths to auto and removed the top marginTabsComponent/styles.scss- Set the height to 100%, utilizing flex to allow the contents to grow but not overflow. Limited the overflow scrolling to the inner table versus the entire containerTableDetailPage/styles.scss- Switched from fixed to absolute positioning so it would stop overflowing, removed the background and adjusted the positioning at smaller sizes so it wouldn't overlapTableDetailPage/index.tsx- Removed the visibility handlers that hid the Collapse all functionality and instead rotated it above the tabs at small enough sizesMotivation and Context
Scrolling in the container would cause the tabs components to overflow out of position
Before
After
How Has This Been Tested?
Manually and comparison against production
CheckList